Restore sidebar transition when switching from/to small screen/"sticky" sidebar #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 3a238c8 |
bvaughn
reviewed
Oct 10, 2017
There was a problem hiding this comment.
I'm actually not sure if we want this transition 😁 Although transform was totally mis-typed before which was unintentional. I'm not sure it looks better with it enabled though.
What do you think, @joecritch?
Yeah, actually asked that myself, too. 😉 |
|
We should definitely either fix this property name or remove it entirely, I'm just not sure which. (Leaning towards removing entirely but will see if @joecritch agrees) |
|
@bvaughn Yeah, no transitions when resizing are intentional :) |
|
So the typo ( |
|
@bvaughn Sorry, I meant the transitions weren’t intentional. But no sweat, I’ll check out master tomorrow to see how it looks |
|
Please feel free to change it however you'd like Joe (or just shoot me a Hangouts message with clarification and I'll make the change!) 😄 |
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
…s#123) * 翻译了 effect hook 的前半部分 * hooks-effect 翻译完成 * Update hooks-effect.md 修改一些问题 * Update hooks-effect.md * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update hooks-effect.md * Update hooks-effect.md * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update hooks-effect.md quota * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update hooks-effect.md * Update hooks-effect.md * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update hooks-effect.md * docs:modify hooks-effect doc * Update hooks-effect.md * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update content/docs/hooks-effect.md Co-Authored-By: Crazydogs <crazydogazrael@gmail.com> * Update hooks-effect.md * Update hooks-effect.md * Update hooks-effect.md * Update hooks-effect.md * Update hooks-effect.md * Update hooks-effect.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.